Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for pcsretirement #406

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Workaround for pcsretirement #406

merged 2 commits into from
Oct 31, 2023
+70 −5

Conversation

GioSensation
Copy link
Member

@GioSensation GioSensation commented Oct 31, 2023 •
edited
Loading

Reviewer: @shakyShane
Asana: https://app.asana.com/0/1200277586140538/1205801189140493/f

Description

Fix for pcsretirement. They use the for attribute improperly and that tripped up our algo 🤦‍♂️.

Steps to test

Form added to the suite.

@GioSensation
Workaround for pcsretirement
057ab8c 
Signed-off-by: Emanuele Feliziani <[email protected]>
@GioSensation
Better fix
40a035f 
Signed-off-by: Emanuele Feliziani <[email protected]>
@GioSensation GioSensation self-assigned this Oct 31, 2023
@GioSensation GioSensation changed the title Ema/minor fix Workaround for pcsretirement Oct 31, 2023
@GioSensation GioSensation marked this pull request as ready for review October 31, 2023 08:44
@GioSensation GioSensation merged commit 3b8211a into main Oct 31, 2023
1 check passed
@GioSensation GioSensation deleted the ema/minor-fix branch October 31, 2023 09:06
This was referenced Oct 31, 2023
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

Assignees

@GioSensation GioSensation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GioSensation @shakyShane